Skip to content

Commit

Permalink
chore: bump runtime version (#90)
Browse files Browse the repository at this point in the history
* chore: bump runtime version

* Put comments on new line to make healthscore succeed
  • Loading branch information
WilliamBergamin authored Aug 2, 2024
1 parent bcd3584 commit 1a5266a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/bundler/esbuild_bundler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ export const EsbuildBundler = {
const result = await esbuild.build({
entryPoints: [options.entrypoint],
platform: "browser",
target: "deno1", // TODO: the versions should come from the user defined input
// TODO: the versions should come from the user defined input

Check warning on line 19 in src/bundler/esbuild_bundler.ts

View workflow job for this annotation

GitHub Actions / Health Score

src/bundler/esbuild_bundler.ts#L19

Problematic comment ("TODO") identified
target: "deno1",
format: "esm", // esm format stands for "ECMAScript module"
bundle: true, // inline any imported dependencies into the file itself
absWorkingDir: options.absWorkingDir,
Expand Down
2 changes: 1 addition & 1 deletion src/install_update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const updateDependencies = async () => {
// project as a means to cache the changes
if (!updateResp.error) {
try {
// TODO :: This try/catch should be nested within createUpdateResp
// TODO: This try/catch should be nested within createUpdateResp

Check warning on line 45 in src/install_update.ts

View workflow job for this annotation

GitHub Actions / Health Score

src/install_update.ts#L45

Problematic comment ("TODO") identified
// but doing so surfaces an issue with the --allow-run flag not
// being used, despite its presence and success at this level
runBuildHook();
Expand Down
2 changes: 1 addition & 1 deletion src/libraries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const DENO_SLACK_HOOKS = "deno_slack_hooks";
export const DENO_SLACK_RUNTIME = "deno_slack_runtime";

export const VERSIONS = {
[DENO_SLACK_RUNTIME]: "1.1.1",
[DENO_SLACK_RUNTIME]: "1.1.2",
[DENO_SLACK_HOOKS]: hooksVersion,
};

Expand Down

0 comments on commit 1a5266a

Please sign in to comment.