Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all references to geometric points conform to standards #30

Open
skytreader opened this issue Feb 27, 2018 · 3 comments
Open

Make all references to geometric points conform to standards #30

skytreader opened this issue Feb 27, 2018 · 3 comments

Comments

@skytreader
Copy link
Owner

skytreader commented Feb 27, 2018

See: https://github.com/skytreader/PyGame-Objects/wiki/Standards-and-Conventions

Make it so that all tuples describing positions describe them as (row, col). draw_offset currently uses (width, height) and is confusing.

@skytreader
Copy link
Owner Author

skytreader commented Feb 27, 2018

On the other hand, check with pygame conventions and conform to that: https://www.pygame.org/docs/ref/draw.html#pygame.draw.line

Looks like pygame.draw.line expects points in the actual (x, y) format; column indices go first before row indices.

skytreader added a commit that referenced this issue Mar 15, 2018
The problem here _might be_ related to #30.
@skytreader
Copy link
Owner Author

More notes on PyGame conventions: font.size returns (width, height).

@skytreader skytreader changed the title draw_offset is inconsistent Make all references to geometric points conform to standards Mar 24, 2018
skytreader added a commit that referenced this issue Mar 28, 2018
@skytreader
Copy link
Owner Author

Violation: Docstring for Drawable constructor says that draw_offset is a (width, height) tuple but GameScreen._is_drawable_clicked uses index 1 for width and index 0 for height.

skytreader added a commit that referenced this issue Apr 11, 2018
Also, uncover some more inconsistencies for #30.
skytreader added a commit that referenced this issue Apr 12, 2018
Work for #30. Color Blocks Game looks good but tests are not passing yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant