perf(skymp5-server): avoid copying in DynamicFields.set (mp.set)

[nic11]

Important

Optimize DynamicFields::Set to avoid copying and refactor message handling in MpObjectReference for improved performance.

• Performance:
  • Optimize DynamicFields::Set in DynamicFields.cpp by using std::move to avoid unnecessary copying of nlohmann::json objects.
• Refactoring:
  • Replace SendPropertyToListeners and SendPropertyTo with SendMessageToActorListeners in MpObjectReference.cpp for sending messages to actor listeners.
  • Refactor SetProperty in MpObjectReference.cpp to use std::move for nlohmann::json parameter.
• Misc:
  • Include MessageBase.h and UpdatePropertyMessage.h in MpObjectReference.cpp and MpObjectReference.h for message handling.

^{This description was created by for 8a3b750. It will automatically update as commits are pushed.}

[nic11]

Ideally should spend some more time on indev(?) because of potential untesed error (host)

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 8a3b750 in 13 seconds

More details

• Looked at 219 lines of code in 5 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skymp5-server/cpp/server_guest_lib/MpObjectReference.cpp:704

• Draft comment:
  Consider changing the parameter type of newValue in CreatePropertyMessage and PreparePropertyMessage to pass by value and use std::move to avoid unnecessary copies, similar to the change made in SetProperty.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The change from passing by const reference to pass by value and using std::move is a performance improvement. However, the same change should be applied consistently across the codebase.

Workflow ID: wflow_0dB0JNgOmH9HZf5C

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.