Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Unsupported features should fail with non-zero exit code #2775

Open
romilbhardwaj opened this issue Nov 12, 2023 · 5 comments · May be fixed by #4515
Open

[Core] Unsupported features should fail with non-zero exit code #2775

romilbhardwaj opened this issue Nov 12, 2023 · 5 comments · May be fixed by #4515
Labels
good first issue Good for newcomers

Comments

@romilbhardwaj
Copy link
Collaborator

Currently, if a feature is not supported by a specific cloud, we exit with a zero exit code. Example:

(base) ➜  ~ sky stop romil
D 11-12 13:32:43 skypilot_config.py:158] Using config path: /Users/romilb/.sky/config.yaml
D 11-12 13:32:43 skypilot_config.py:161] Config loaded:
D 11-12 13:32:43 skypilot_config.py:161] None
D 11-12 13:32:43 skypilot_config.py:173] Config syntax check passed.
Stopping 1 cluster: romil. Proceed? [Y/n]:
The following features are not supported by Kubernetes:
	Feature  Reason
	stop     Kubernetes does not support stopping VMs.
Stopping 1 cluster ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━   0% -:--:--
(base) ➜ ~ echo $?
0

This is undesirable because with zero exit code, other programs/our tests may assume the operation completed successfully.
@romilbhardwaj romilbhardwaj added the good first issue Good for newcomers label Nov 12, 2023
brannt added a commit to brannt/skypilot that referenced this issue Dec 23, 2023
@brannt
[Core] Unsupported features should fail with non-zero exit code skypi…
1ce56ea 
…lot-org#2775
brannt added a commit to brannt/skypilot that referenced this issue Dec 24, 2023
@brannt
[Core] Unsupported features should fail with non-zero exit code skypi…
9063d67 
…lot-org#2775
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jul 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2024
@romilbhardwaj
Copy link
Collaborator Author

Reopening - ran into this with sky status --endpoint on an unsupported cloud (lambda). Using exit code 0 made it harder to script around it.

@romilbhardwaj romilbhardwaj reopened this Aug 28, 2024
@github-actions github-actions bot removed the Stale label Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 27, 2024
@romilbhardwaj romilbhardwaj linked a pull request Dec 29, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Fail with non-zero exit code when using unsupported features skypilot-org/skypilot
1 participant
@romilbhardwaj