Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] Automatically source the sky environment for dev mode #4453

Open
cblmemo opened this issue Dec 10, 2024 · 4 comments
Open

[Dev] Automatically source the sky environment for dev mode #4453

cblmemo opened this issue Dec 10, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@cblmemo
Copy link
Collaborator

cblmemo commented Dec 10, 2024

It is a little bit tedious to manually source ~/skypilot-runtime/bin/activate for dev on sky serve/managed jobs. Can we support automatically activate it for dev mode (e.g. SKYPILOT_DEV=1)?

Version & Commit info:

  • sky -v: PLEASE_FILL_IN
  • sky -c: PLEASE_FILL_IN
@cg505
Copy link
Collaborator

cg505 commented Dec 11, 2024

We could add it to bashrc or something, but I would be concerned that we'd accidentally make some feature rely on it.

@cblmemo
Copy link
Collaborator Author

cblmemo commented Dec 19, 2024

We could add it to bashrc or something, but I would be concerned that we'd accidentally make some feature rely on it.

I see. Then how about adding a shortcut for activate the environment? e.g. adding the following to bashrc:

alias activate_sky_env="source ~/skypilot-runtime/bin/activate"

with this we can 1-click activate the env which will also make life easier ;)

@cg505
Copy link
Collaborator

cg505 commented Dec 19, 2024

I like it :) can we make the alias shorter? (sky-env?)

@Michaelvll Michaelvll removed the OSS label Dec 19, 2024
@cblmemo
Copy link
Collaborator Author

cblmemo commented Dec 21, 2024

I like it :) can we make the alias shorter? (sky-env?)

That sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants