diff --git a/.travis.yml b/.travis.yml index 26f3a84550..09a31498cb 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,7 @@ language: objective-c rvm: 2.0.0 before_install: - - gem install danger danger-xcode_summary danger-prose xcpretty xcpretty-json-formatter + - gem install danger danger-xcode_summary xcpretty xcpretty-json-formatter script: - xcodebuild -project ios/sdk/WeexSDK.xcodeproj test -scheme WeexSDKTests CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO -destination 'platform=iOS Simulator,name=iPhone 6' | XCPRETTY_JSON_FILE_OUTPUT=ios/sdk/xcodebuild.json xcpretty -f `xcpretty-json-formatter` - bundle exec danger \ No newline at end of file diff --git a/Dangerfile b/Dangerfile index 1eeda16b88..9faa2f1498 100644 --- a/Dangerfile +++ b/Dangerfile @@ -4,8 +4,12 @@ warn("Big PR") if git.lines_of_code > 500 xcode_summary.ignored_files = '**/Pods/**' xcode_summary.report 'ios/sdk/xcodebuild.json' -prose.check_spelling "ios/sdk/**/*.h" -prose.check_spelling "ios/sdk/**/*.m" + +# oc_files = (git.modified_files + git.added_files).select do |line| + line.end_with?(".h") || line.end_with?(".m") || line.end_with?(".mm") +end + +# prose.check_spelling oc_files # Find reviewers without parsing blame information # from files matching to 'Pods/*' diff --git a/Gemfile b/Gemfile index 1134f877b0..d9bb35f8ab 100644 --- a/Gemfile +++ b/Gemfile @@ -5,8 +5,8 @@ gem "xcpretty" gem "xcpretty-json-formatter" gem "danger" gem "danger-xcode_summary" -gem "danger-prose" +# gem "danger-prose" # gem "danger-clorox" # gem "danger-mention" diff --git a/Gemfile.lock b/Gemfile.lock index 4c5f7a2552..660dd81d9b 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -24,8 +24,6 @@ GEM terminal-table (~> 1) danger-plugin-api (1.0.0) danger (> 2.0) - danger-prose (2.0.3) - danger danger-xcode_summary (0.1.0) danger-plugin-api (~> 1.0) faraday (0.11.0) @@ -57,7 +55,6 @@ PLATFORMS DEPENDENCIES danger - danger-prose danger-xcode_summary xcpretty xcpretty-json-formatter