Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality tests for dumpreader and SingleSpeciesAnalyzer #28

Closed
skuschel opened this issue Jun 1, 2015 · 3 comments
Closed

Equality tests for dumpreader and SingleSpeciesAnalyzer #28

skuschel opened this issue Jun 1, 2015 · 3 comments

Comments

@skuschel
Copy link
Owner

skuschel commented Jun 1, 2015

Implement Equality tests for dumpreader and SingleSpeciesAnalyzer. This allows that ParticleAnalyzer can be added together without adding Particles twice, in case they overlap. It will also allow to easily check if a particle analyzer contains particles of another.

@skuschel
Copy link
Owner Author

Equality tests for dumpreader have been implemented 341cdae. Its not straigt forward what == should mean for singlespecies or multispecies objects including the option, that the particle lists might be reduced due to compression functions (like taking only particles with gamma > 2 or similar). Concept needed.

@skuschel
Copy link
Owner Author

Regarding #117 it may be useful to define "dr1 == dr2" to be True if they are returning the same particles in the same order (although from a possibly different dump)?

@skuschel skuschel added particles Field core routines affected and removed particles labels Dec 19, 2017
@skuschel skuschel added particles and removed Field core routines affected labels Jan 30, 2019
@skuschel skuschel added the wontfix Things not to be changed label Jul 9, 2024
@skuschel
Copy link
Owner Author

skuschel commented Jul 9, 2024

If it becomes necessary to implement equality tests for singlespecies or multispecies objects, we can still do it. There is no obvious way here and also no obvious benefit. Closing the issue.

@skuschel skuschel closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant