Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] allow list of types in estimator tag register tests #53

Merged
merged 5 commits into from
Sep 9, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Aug 28, 2023

Minor update to specification conformance tests in the estimator tag register, to allow listst of estimator types

@fkiraly fkiraly added enhancement module:base-framework BaseObject, registry, base framework labels Aug 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.03% ⚠️

Comparison is base (0d8bd68) 70.91% compared to head (e0a395d) 70.89%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   70.91%   70.89%   -0.03%     
==========================================
  Files          93       93              
  Lines        4962     4964       +2     
  Branches      900      902       +2     
==========================================
  Hits         3519     3519              
- Misses       1205     1206       +1     
- Partials      238      239       +1     
Files Changed Coverage Δ
skpro/registry/tests/test_tags.py 88.88% <33.33%> (-11.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 27aa6f5 into main Sep 9, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:base-framework BaseObject, registry, base framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants