Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Chi-Squared Distribution #217

Merged
merged 10 commits into from
Apr 25, 2024
Merged

[ENH] Chi-Squared Distribution #217

merged 10 commits into from
Apr 25, 2024

Conversation

sukjingitsit
Copy link
Contributor

Reference Issues/PRs

Addresses #22 for chi-squared case

What does this implement/fix? Explain your changes.

Implements some methods for chi-squared distribution

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Current state of code, and what all capabilities need to be modified / made better (particularly, I am trying to implement energy and make ppf more native than a scipy wrapper)

Did you add any tests for the change?

Nope

Any other comments?

PR checklist

For all contributions
  • [ No] I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • [Yes ] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

Thanks for contributing!
-->

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution!

Code formatting checks are failing, see here for a guide how to set this up locally:
https://www.sktime.net/en/stable/developer_guide/coding_standards.html

For the energy, let me know if you need help. Does the reference from the issue not have an explicit formula?

@sukjingitsit
Copy link
Contributor Author

I do not understand what the build issue is, as it doesn't seem to show the files I modified, rather some other files

@fkiraly
Copy link
Collaborator

fkiraly commented Mar 24, 2024

note sure, I've restarted the tests - let's see.

@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators implementing algorithms Implementing algorithms, estimators, objects native to skpro labels Mar 24, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented Mar 24, 2024

failures seem genuine - methods return unexpected values. Have you run check_estimator on the distribution?

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Updated with new extension contract.

@fkiraly fkiraly changed the title [ENH] Chi-Squared Distribution #22 [ENH] Chi-Squared Distribution Apr 25, 2024
@fkiraly fkiraly merged commit 3f9ca4a into sktime:main Apr 25, 2024
17 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement implementing algorithms Implementing algorithms, estimators, objects native to skpro module:probability&simulation probability distributions and simulators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants