Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] lifelines accelerated failure time models #250

Closed
1 of 2 tasks
fkiraly opened this issue Apr 17, 2024 · 0 comments · Fixed by #260
Closed
1 of 2 tasks

[ENH] lifelines accelerated failure time models #250

fkiraly opened this issue Apr 17, 2024 · 0 comments · Fixed by #260
Labels
enhancement good first issue Good for newcomers implementing algorithms Implementing algorithms, estimators, objects native to skpro module:survival&time-to-event module for time-to-event prediction aka survival prediction

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Apr 17, 2024 •
edited
Loading

This issue tracks remaining lifelines accelerated failure time models to interface.
These can be added only after there is a representation of the respective distributions in skpro:

Code location: https://github.com/CamDavidsonPilon/lifelines/tree/master/lifelines/fitters
@fkiraly fkiraly added enhancement good first issue Good for newcomers implementing algorithms Implementing algorithms, estimators, objects native to skpro module:survival&time-to-event module for time-to-event prediction aka survival prediction labels Apr 17, 2024
@fkiraly fkiraly mentioned this issue Apr 19, 2024
Merged
fkiraly added a commit that referenced this issue Apr 19, 2024
@fkiraly
[ENH] log-normal AFT model from lifelines (#258)
369cee7 
Adds the log-normal AFT model from `lifelines`.

Towards #250
@fkiraly fkiraly mentioned this issue Apr 19, 2024
Merged
fkiraly added a commit that referenced this issue Apr 20, 2024
@fkiraly
[ENH] log-logistic/Fisk AFT model from lifelines (#260)
05127dd 
Adds the log-logistic/Fisk AFT model from `lifelines`.

Also fixes a bug with the recently added log-normal model that invoked
the wrong estimator (see #258).

Closes #250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Good for newcomers implementing algorithms Implementing algorithms, estimators, objects native to skpro module:survival&time-to-event module for time-to-event prediction aka survival prediction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] log-logistic/Fisk AFT model from lifelines sktime/skpro
1 participant
@fkiraly