-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error generating fixtures Enyaq 80 #114
Comments
yeah, i also just encountered it, you beat me to reporting it :) for i in info status air_conditioning positions health charging maintenance driving_range;
do poetry run myskoda --user USERNAME --password PASSWORD gen-fixtures --vehicle VIN --name i_want_weekend_$i --description "Is it weekend yet?" --file filename_here_$i get $i;
done |
I think this works as designed. An error is logged for any endpoint which returns an error but the command continues and completes and the fixture file is generated (including the expected error for the given endpoint). The VIN being leaked into the fixture in case of an error is covered in #100 |
The problem here is that when using the Silently passing on, or reporting in a fixture that this isnt supported would be even neater |
Yeah the error being logged is confusing but the end result is a usable fixture. Since it's just a helper tool to generate fixtures I'm not too concerned about it being super polished. But a PR is always an option 😄 |
We have decided that the traceback being present in the fixtures is actually what we want. This way we get more detailed information about error states. If someone wants to silence the CLI about this while generating the fixtures, that's a cool improvement. |
when generating all fixtures using the myskoda client I get an error at the trip-statistics endpoint
The text was updated successfully, but these errors were encountered: