Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreliable location (North Pole) #233

Open
luc-ass opened this issue Nov 8, 2023 · 6 comments
Open

Unreliable location (North Pole) #233

luc-ass opened this issue Nov 8, 2023 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers no-stale

Comments

@luc-ass
Copy link

luc-ass commented Nov 8, 2023

Describe the bug
The API seems to return unreliable location data under some circumstances. In my case it reports lat 0, long 0 latitude: 134.217726, longitude: -161.061275 if I park my car (Superb 3V) in one specific underground garage. This causes to look really funny on the map card.

Is this working in MySkoda app?*
Location history is not visible within the app

Latest working release
As far as I know, this was always the case

Debug logs
If applicable, add debug logs. See README on how to enable debug logs with response debugging.

Installation:

  • Home Assistant variant: hass.io 11.1 with Home Assistant (2023.11.1) Supervisor (2023.10.1)
  • Python version: not sure how to find that
  • Python library versions: not sure how to find that

Additional context
This is what it looks like:
Bildschirmfoto 2023-11-08 um 10 03 30

Perhaps implausible data can be ignored to improve on this? If you let me know where to look for the location processing, I'd happily create a pull request.

@luc-ass luc-ass added the bug Something isn't working label Nov 8, 2023
@WebSpider WebSpider added the good first issue Good for newcomers label Nov 8, 2023
@WebSpider
Copy link
Contributor

You seem to be able to reproduce this quite easily. Can you see what the state of the device tracker for your car is?

HA > Dev tools >States > filter the device tracker > state attribute yaml

@luc-ass
Copy link
Author

luc-ass commented Nov 8, 2023

I'll check on it when doing groceries next week. Anything else that should be logged?

@luc-ass
Copy link
Author

luc-ass commented Nov 15, 2023

Okay, I caught it:

source_type: gps
latitude: 134.217726
longitude: -161.061275
gps_accuracy: 0
model: Škoda Superb Combi Style/2017-11-10
entity_picture: https://ip-modcwp.azureedge.net/xxxxxxxxxxxxx_front1080.png
assumed_state: true
icon: si:skoda
friendly_name: Skoda Superb Position

Looks like gps_accuracy: 0 is a good indicator on whether to use the information or discard it.

@WebSpider
Copy link
Contributor

Okay, I caught it:

source_type: gps
latitude: 134.217726
longitude: -161.061275
gps_accuracy: 0
model: Škoda Superb Combi Style/2017-11-10
entity_picture: https://ip-modcwp.azureedge.net/xxxxxxxxxxxxx_front1080.png
assumed_state: true
icon: si:skoda
friendly_name: Skoda Superb Position

Looks like gps_accuracy: 0 is a good indicator on whether to use the information or discard it.

Thanks a lot! This will make it easier to fix this 👍

Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 16, 2024
@luc-ass
Copy link
Author

luc-ass commented Jan 16, 2024

This is still active

@github-actions github-actions bot removed the stale label Jan 17, 2024
@dvx76 dvx76 added the no-stale label Jan 20, 2024
@dvx76 dvx76 self-assigned this Feb 6, 2024
@dvx76 dvx76 removed their assignment Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers no-stale
Projects
None yet
Development

No branches or pull requests

4 participants