Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IS 1074 fix externalGas calculation #1999

Merged
merged 9 commits into from
Sep 25, 2024
Merged

IS 1074 fix externalGas calculation #1999

merged 9 commits into from
Sep 25, 2024

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Sep 19, 2024 •
edited by DmytroNazarenko
Loading

fixes https://github.com/skalenetwork/internal-support/issues/1074

fixed externalGas calculation, added patch externalGasPatch for it

added unit test that send txns from a suspicious accounts before and after patch activation
ran load tests with POW transactions on devnet for a week - bug hasn't been reproduced

no performance impact

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

dimalit
dimalit requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@dimalit dimalit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

libethereum/Transaction.cpp Outdated Show resolved Hide resolved
@olehnikolaiev olehnikolaiev marked this pull request as ready for review September 24, 2024 10:40
kladkogex
kladkogex previously approved these changes Sep 24, 2024
View reviewed changes
@DmytroNazarenko DmytroNazarenko merged commit 7c8e79a into develop Sep 25, 2024
7 checks passed
@DmytroNazarenko DmytroNazarenko deleted the bug/IS-1074 branch September 25, 2024 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@kladkogex kladkogex kladkogex approved these changes

@dimalit dimalit dimalit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olehnikolaiev @dimalit @kladkogex @DmytroNazarenko