Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKALED-1900 Release build #1967

Closed
wants to merge 4 commits into from

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented Aug 21, 2024

  1. All dependencies, as well as skaled, are built with -O3 and without -g.
  2. -rdynamic removed
  3. -s added to linker options ("strip")

Testing:
1

ojdump -h skaled | grep debug
nm -a skaled

2 Execute strip command on skaled and see that it's size didn't change
3 ojdump -h skaled | grep debug on all project libraries shows no result too.

skaled binary size 29821336

Consequences:

  1. Stack trace printed by skaled on crash will not contain any function names.
  2. gdb, when attached, will not be able to see any function names also.
  3. same for addr2line

See alternative PR #1969

@dimalit dimalit linked an issue Aug 23, 2024 that may be closed by this pull request
@dimalit dimalit closed this Aug 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove debug library builds from release
1 participant