1932_better_consensus_patch_timestamp #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SUGGESTIONS BEFORE MERGE:
|
dimalit
approved these changes
Jul 3, 2024
olehnikolaiev
approved these changes
Jul 3, 2024
DmytroNazarenko
approved these changes
Jul 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement in patch handling, that makes sure we always take the timestamp of the previous block and there is not concurrency due to catchup
Currently it takes the lastblock timestamp, which can potentially change due to catchup
This bug never happened in tests, the fix is just to cleanup the code