Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/skaled 1877 support block hash #1884

Merged
merged 3 commits into from
May 4, 2024

Conversation

dimalit
Copy link
Contributor

@dimalit dimalit commented May 3, 2024

fixes #1877

Added support of "blockHash" parameter to eth_getLogs call.
Spec: https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getlogs

  1. No other calls are altered.
  2. Error is thrown in case of presence of fromBlock or toBlock parameters together with blockHash or if block hash cannot be parsed.
  3. In case of non-existing block hash return empty response.

Tests:

  1. JsonRpcSuite/getLogs_blockHash
  2. Manual sending requests to https://nodes.mewapi.io/rpc/eth to compare cases mentioned above.

@dimalit dimalit linked an issue May 3, 2024 that may be closed by this pull request
@dimalit dimalit merged commit 55f1b96 into v3.19.0 May 4, 2024
5 checks passed
@dimalit dimalit deleted the feature/SKALED-1877-support-blockHash branch May 4, 2024 01:33
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add blockHash support to JSON-RPC API
3 participants