Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1780 absence tracer in params #1809

Merged
merged 11 commits into from
Feb 28, 2024
Merged

Conversation

kladkogex
Copy link
Collaborator

@kladkogex kladkogex commented Feb 9, 2024

Geth accepts both empty parameter and "{}" parameter in debug_trace* requests

Since json-rpc library used in skaled does not support variable number of parameters,
I added code that adds "{}" to to the parameters if a user submitted to last parameter

A corresponding test has been added to tracer.ts and runs as part of github actions

Also removed some dead code as a part of the pull request

Note - this pull request needs to go in after the previous one in tracing is accepted since it includes changes from the previous one

@kladkogex kladkogex added this to the SKALE 2.3 milestone Feb 9, 2024
@kladkogex kladkogex self-assigned this Feb 9, 2024
@DmytroNazarenko DmytroNazarenko removed this from the SKALE 2.3 milestone Feb 9, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 42.69%. Comparing base (dbac33c) to head (e35ee3a).
Report is 1 commits behind head on v3.17.2.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           v3.17.2    #1809      +/-   ##
===========================================
- Coverage    42.69%   42.69%   -0.01%     
===========================================
  Files          392      392              
  Lines        57235    57243       +8     
===========================================
  Hits         24439    24439              
- Misses       32796    32804       +8     

@kladkogex kladkogex merged commit 5147506 into v3.17.2 Feb 28, 2024
6 of 7 checks passed
@kladkogex kladkogex deleted the 1780_absence_tracer_in_params branch February 28, 2024 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaled returns the error message on absence tracer method in params
3 participants