Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt some of the precompiled contracts to process schain groups logic #1702

Closed
1 task done
olehnikolaiev opened this issue Oct 20, 2023 · 6 comments · Fixed by #1713
Closed
1 task done

adopt some of the precompiled contracts to process schain groups logic #1702

olehnikolaiev opened this issue Oct 20, 2023 · 6 comments · Fixed by #1713
Assignees
@olehnikolaiev
Labels
enhancement New feature or request epic:oracle Oracle
Milestone
SKALE 2.3

Comments

@olehnikolaiev
Copy link
Contributor

olehnikolaiev commented Oct 20, 2023 •
edited by DmytroNazarenko
Loading

need to adapt some of the precompiled smart contracts like getConfigVariableUint256 to return the variables values depending on current block timestamp

Tasks
Beta Give feedback
  1. add owner field to the nodes in nodesGroup section in skale config skale-admin#1000
    enhancement epic:oracle
    DmytroNazarenko

How it works: https://github.com/skalenetwork/internal-support/blob/main/docs/issues-and-investigations/precompiledPatch.md
@olehnikolaiev olehnikolaiev self-assigned this Oct 20, 2023
@olehnikolaiev olehnikolaiev added this to the SKALE 2.3 milestone Oct 20, 2023
@PolinaKiporenko PolinaKiporenko moved this to Ready For Pickup in SKALE Engineering 🚀 Oct 20, 2023
@olehnikolaiev olehnikolaiev mentioned this issue Oct 20, 2023
Closed
@olehnikolaiev olehnikolaiev moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 Oct 20, 2023
@DmytroNazarenko DmytroNazarenko added the enhancement New feature or request label Oct 20, 2023
@DmytroNazarenko
Copy link
Collaborator

Add to 2.3 to unblock on-chain oracle usage

@olehnikolaiev olehnikolaiev mentioned this issue Oct 31, 2023
Merged
@olehnikolaiev olehnikolaiev moved this from In Progress to Code Review in SKALE Engineering 🚀 Oct 31, 2023
@olehnikolaiev olehnikolaiev linked a pull request Nov 1, 2023 that will close this issue
Bug/1702 adopt precompiled oracle #1713
Merged
kladkogex added a commit that referenced this issue Nov 6, 2023
@kladkogex
#1702 renamed owner to nodeAddress
ee9c48a
kladkogex added a commit that referenced this issue Nov 6, 2023
@kladkogex
#1702 changed [] to at() for safe vector access
aa4c0d8
kladkogex added a commit that referenced this issue Nov 6, 2023
@kladkogex
#1702 added param validation
95215c7
kladkogex added a commit that referenced this issue Nov 6, 2023
@kladkogex
#1702 added a log record if node info is empty in config
4d55443
kladkogex added a commit that referenced this issue Nov 6, 2023
@kladkogex
#1702 changed assertion to runtime error
7f136c5
kladkogex added a commit that referenced this issue Nov 6, 2023
@kladkogex
#1702 changed assertion to runtime error
ea28913
kladkogex added a commit that referenced this issue Nov 6, 2023
@kladkogex
#1702 changed to standard boost library
3652a82
kladkogex added a commit that referenced this issue Nov 7, 2023
@kladkogex
#1702 Use start with
47bc822
kladkogex added a commit that referenced this issue Nov 7, 2023
@kladkogex
#1702 simplified parsing
7c8653a
kladkogex added a commit that referenced this issue Nov 7, 2023
@kladkogex
#1702 simplified parsing
73d98ee
kladkogex added a commit that referenced this issue Nov 7, 2023
@kladkogex
Revert "#1702 simplified parsing"
2d582e7 
This reverts commit 73d98ee.
kladkogex added a commit that referenced this issue Nov 7, 2023
@kladkogex
Revert "#1702 simplified parsing"
df1aad9 
This reverts commit 7c8653a.
olehnikolaiev added a commit that referenced this issue Nov 7, 2023
@olehnikolaiev
#1702 improve code quality
80618dd
olehnikolaiev added a commit that referenced this issue Nov 8, 2023
@olehnikolaiev
#1702 use common approach to access config variables
582b526
olehnikolaiev added a commit that referenced this issue Nov 8, 2023
@olehnikolaiev
#1702 improve code quality
ea694fc
olehnikolaiev added a commit that referenced this issue Nov 13, 2023
@olehnikolaiev
#1702 improve input proccessing for precompileds
ca16ebf
olehnikolaiev added a commit that referenced this issue Nov 13, 2023
@olehnikolaiev
#1702 add more checks
4995613
olehnikolaiev added a commit that referenced this issue Nov 13, 2023
@olehnikolaiev
#1702 improve tests
edd62d4
olehnikolaiev added a commit that referenced this issue Nov 22, 2023
@olehnikolaiev
#1702 pass historic publicKey instead of address
4b51081
@PolinaKiporenko PolinaKiporenko moved this from Code Review to In Progress in SKALE Engineering 🚀 Nov 22, 2023
olehnikolaiev added a commit that referenced this issue Nov 22, 2023
@olehnikolaiev
#1702 fix tests
a504090
olehnikolaiev added a commit that referenced this issue Nov 22, 2023
@olehnikolaiev
#1702 add more tests
1a67380
olehnikolaiev added a commit that referenced this issue Nov 22, 2023
@olehnikolaiev
#1702 change [] to at()
7700738
@olehnikolaiev olehnikolaiev moved this from In Progress to Code Review in SKALE Engineering 🚀 Nov 22, 2023
olehnikolaiev added a commit that referenced this issue Nov 22, 2023
@olehnikolaiev
#1702 change [] to at()
c8921f6
olehnikolaiev added a commit that referenced this issue Nov 22, 2023
@olehnikolaiev
#1702 change [] to at()
23a5437
@olehnikolaiev olehnikolaiev moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Nov 23, 2023
@DmytroNazarenko
Copy link
Collaborator

skaled: 3.18.0-beta.0
patch: precompiledPatchTimestamp

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jan 23, 2024
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jan 23, 2024
@OleksanderSalamatov
Copy link

Verified

skaled: 3.18.0-beta.1

After rotations txs with verification of oracle result processed normally, after snapshots were made state root is equal on all nodes

regular node:

> eth.getTransactionReceipt("0x09e493fa038076fa671435e20ea6c8910593cb2c351a034d4d5be0d312a8f49e")
{
  blockHash: "0xa4d592cb7a771f08756eebbadf3dcba65d36ba22067691a834c011fafc4a9746",
  blockNumber: 19329,
  contractAddress: null,
  cumulativeGasUsed: 242545,
  from: "0x487360568fe5ee4ae5c75782d5f63e9935b0e512",
  gasUsed: 215939,
  logs: [],
  logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  status: "0x1",
  to: "0xaaab993e4b7b22f20db2a28c627e3cf84e991473",
  transactionHash: "0x09e493fa038076fa671435e20ea6c8910593cb2c351a034d4d5be0d312a8f49e",
  transactionIndex: 1
}
> eth.getTransactionReceipt("0x8904cdff383ba8cd0ca96042707467acfa886d6b88e6e66bbb63273b1937deaf")
{
  blockHash: "0xf4faf834866d1073ccacd0a5bec367d8abacecc43b03aefb7b2d55db6d3642ea",
  blockNumber: 19436,
  contractAddress: null,
  cumulativeGasUsed: 322363,
  from: "0x487360568fe5ee4ae5c75782d5f63e9935b0e512",
  gasUsed: 215939,
  logs: [],
  logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  status: "0x1",
  to: "0xaaab993e4b7b22f20db2a28c627e3cf84e991473",
  transactionHash: "0x8904cdff383ba8cd0ca96042707467acfa886d6b88e6e66bbb63273b1937deaf",
  transactionIndex: 4
}

catchuped node:

> eth.getTransactionReceipt("0x09e493fa038076fa671435e20ea6c8910593cb2c351a034d4d5be0d312a8f49e")
{
  blockHash: "0xa4d592cb7a771f08756eebbadf3dcba65d36ba22067691a834c011fafc4a9746",
  blockNumber: 19329,
  contractAddress: null,
  cumulativeGasUsed: 242545,
  from: "0x487360568fe5ee4ae5c75782d5f63e9935b0e512",
  gasUsed: 215939,
  logs: [],
  logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  status: "0x1",
  to: "0xaaab993e4b7b22f20db2a28c627e3cf84e991473",
  transactionHash: "0x09e493fa038076fa671435e20ea6c8910593cb2c351a034d4d5be0d312a8f49e",
  transactionIndex: 1
}
> eth.getTransactionReceipt("0x8904cdff383ba8cd0ca96042707467acfa886d6b88e6e66bbb63273b1937deaf")
{
  blockHash: "0xf4faf834866d1073ccacd0a5bec367d8abacecc43b03aefb7b2d55db6d3642ea",
  blockNumber: 19436,
  contractAddress: null,
  cumulativeGasUsed: 322363,
  from: "0x487360568fe5ee4ae5c75782d5f63e9935b0e512",
  gasUsed: 215939,
  logs: [],
  logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
  status: "0x1",
  to: "0xaaab993e4b7b22f20db2a28c627e3cf84e991473",
  transactionHash: "0x8904cdff383ba8cd0ca96042707467acfa886d6b88e6e66bbb63273b1937deaf",
  transactionIndex: 4
}

@OleksanderSalamatov
Copy link

Has s problem with archive node, need to be retested.

@OleksanderSalamatov
Copy link

Blocker: #1836

@OleksanderSalamatov
Copy link

Fix versions for archive node:
skaled:3.18.0-historic
admin:2.11.0-sync-node.5

Config calls now do not cause errors with transaction execution on archive node and state root mismatch as a result

Log from archive node:

Reload configuration file Loading configuration from /schain_config/schain_skale-innocent-nasty.json ...
Reload configuration file Parsing configuration JSON ...
Reload configuration file Done, loaded configuration file /schain_config/schain_skale-innocent-nasty.json
2024-03-12 13:11:23.587728   Self-destructing#00000000…
2024-03-12 13:11:23.587764   Self-destructing#00000000…
2024-03-12 13:11:23.587778   Self-destructing#00000000…
2024-03-12 13:11:23.588622   Block sealed #1118117 (#e44eac89…)
2024-03-12 13:11:23.588654   Block stats:BN:1118116:BTS:1710249063:TXS:3:HDRS:11:LOGS:74:SENGS:1:TXRS:40:BLCKS:3:ACCS:199:BQS:1:BDS:288:TSS:0:UTX:0:VTX:0:CMM:868194:KDS:8
2024-03-12 13:11:23.588751   Block 1118117 DB usage is 1828. Piece DB usage is 207886743 bytes
2024-03-12 13:11:23.589309   noteChanged: {chain}
2024-03-12 13:11:23.589763   SWT:27:BFT:15865
2024-03-12 13:11:23.589783   Successfully imported 1 of 1 transactions

Log from core node:

Reload configuration file Loading configuration from /schain_config/schain_skale-innocent-nasty.json ...
Reload configuration file Parsing configuration JSON ...
Reload configuration file Done, loaded configuration file /schain_config/schain_skale-innocent-nasty.json
2024-03-12 13:11:13.290739   Self-destructing#00000000…
2024-03-12 13:11:13.290762   Self-destructing#00000000…
2024-03-12 13:11:13.290819   Self-destructing#00000000…
2024-03-12 13:11:13.291031   Block sealed #1118117 (#e44eac89…)
2024-03-12 13:11:13.291058   Block stats:BN:1118116:BTS:1710249063:TXS:3:HDRS:11:LOGS:76:SENGS:1:TXRS:27:BLCKS:3:ACCS:199:BQS:1:BDS:1859:TSS:0:UTX:0:VTX:0:CMM:2746821:KDS:8
2024-03-12 13:11:13.291142   Block 1118117 DB usage is 1828. Piece DB usage is 207886743 bytes
2024-03-12 13:11:13.291327   noteChanged: {chain}
2024-03-12 13:11:13.291631   SWT:16:BFT:9069
2024-03-12 13:11:13.291641   Successfully imported 1 of 1 transactions

@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olehnikolaiev olehnikolaiev

Labels
enhancement New feature or request epic:oracle Oracle
Projects
SKALE Engineering 🚀
Archived in project
Milestone
SKALE 2.3
Development

Successfully merging a pull request may close this issue.

Bug/1702 adopt precompiled oracle skalenetwork/skaled
4 participants
@DmytroNazarenko @olehnikolaiev @OleksanderSalamatov @PolinaKiporenko