Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let sync node accept and broadcast transactions #1135

Closed
1 task
kladkogex opened this issue Jul 5, 2022 · 6 comments · Fixed by #1651 or skalenetwork/skale-consensus#825
Closed
1 task

Let sync node accept and broadcast transactions #1135

kladkogex opened this issue Jul 5, 2022 · 6 comments · Fixed by #1651 or skalenetwork/skale-consensus#825

Comments

@kladkogex
Copy link
Collaborator

kladkogex commented Jul 5, 2022

If a sync node accepts transactions and broadcasts them to the core 16 nodes, this can
significantly help performance, since transaction broadcast is one of our bottlenecks.

We need to to do two things:

  1. Accept transactions on the sync node and broadcast them to the core nodes.

  2. Open up firewall ports on the core nodes for the sync node, so it can do the broadcast

Tasks

  1. bug
    olehnikolaiev
@DmytroNazarenko
Copy link
Collaborator

What about oracle requests? Should we allow them?

@gannakulikova
Copy link
Contributor

@DmytroNazarenko please update specification according to the changes you are going to make https://github.com/skalenetwork/internal-support/blob/main/docs/specifications/nodes/fullsync-node/fullsync-node-spec.md

@gannakulikova gannakulikova moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 Jul 14, 2022
@gannakulikova gannakulikova moved this from In Progress to Ready For Pickup in SKALE Engineering 🚀 Jul 19, 2022
@gannakulikova
Copy link
Contributor

  • would be good to look at the Polkadot system

@gannakulikova
Copy link
Contributor

Need to review broadcast and DoS protection together with @kladkogex

@gannakulikova gannakulikova moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 Aug 2, 2022
@gannakulikova gannakulikova moved this from In Progress to Code Review in SKALE Engineering 🚀 Aug 17, 2022
@PolinaKiporenko PolinaKiporenko added this to the SKALE 2.3 milestone Aug 11, 2023
@PolinaKiporenko PolinaKiporenko moved this to Ready For Pickup in SKALE Engineering 🚀 Sep 8, 2023
@DmytroNazarenko DmytroNazarenko moved this from Ready For Pickup to In Progress in SKALE Engineering 🚀 Sep 15, 2023
@DmytroNazarenko DmytroNazarenko linked a pull request Sep 18, 2023 that will close this issue
@PolinaKiporenko PolinaKiporenko moved this from In Progress to Code Review in SKALE Engineering 🚀 Sep 18, 2023
@PolinaKiporenko PolinaKiporenko moved this from Code Review to In Progress in SKALE Engineering 🚀 Sep 29, 2023
DmytroNazarenko added a commit that referenced this issue Nov 23, 2023
@PolinaKiporenko PolinaKiporenko moved this from In Progress to Code Review in SKALE Engineering 🚀 Nov 28, 2023
DmytroNazarenko added a commit that referenced this issue Dec 13, 2023
DmytroNazarenko added a commit that referenced this issue Dec 14, 2023
DmytroNazarenko added a commit that referenced this issue Dec 14, 2023
DmytroNazarenko added a commit that referenced this issue Dec 14, 2023
DmytroNazarenko added a commit that referenced this issue Dec 18, 2023
DmytroNazarenko added a commit that referenced this issue Dec 18, 2023
@github-project-automation github-project-automation bot moved this from Code Review to Ready For Release Candidate in SKALE Engineering 🚀 Jan 2, 2024
@DmytroNazarenko DmytroNazarenko linked a pull request Jan 8, 2024 that will close this issue
@DmytroNazarenko
Copy link
Collaborator

skaled: 3.18.0-beta.0

@DmytroNazarenko DmytroNazarenko moved this from Ready For Release Candidate to Merged To Release Candidate in SKALE Engineering 🚀 Jan 23, 2024
@EvgeniyZZ EvgeniyZZ moved this from Merged To Release Candidate to QA in SKALE Engineering 🚀 Jan 23, 2024
@oleksandrSydorenkoJ
Copy link

Verified on regression Network
skaled: 3.18.0-beta.0
Skale chain: playful-joyful-angetenar
sync-node: http://34.218.236.149:10195

ubuntu@sync-node: cat .skale/node_data/schains/playful-joyful-angetenar/schain_playful-joyful-angetenar.json | grep  "multiTransactionMode"
 "multiTransactionMode": true,


2024-01-31 16:04:52.216399   http://localhost:33398 >>> {"id":22743,"jsonrpc":"2.0","method":"eth_sendRawTransaction","params":["0xf9010e826925830186a083030d4094adf0cab6023ddf1814b3778c223fb0d2..."]}
2024-01-31 16:04:52.216801   Queued vaguely legit-looking transaction #64dfadad…
2024-01-31 16:04:52.216894   http://localhost:33398 <<< {"id":22743,"jsonrpc":"2.0","result":"0x64dfadadd5b29b22c6e4b23225bfa4a4dd21aa18f3adb4eb61e2a0b6515a1055"}

2024-01-31 16:04:53.757183   http://localhost:41224 >>> {"id":13,"jsonrpc":"2.0","method":"eth_getTransactionReceipt","params":["0x64dfadadd5b29b22c6e4b23225bfa4a4dd21aa18f3adb4eb61e2a0b6515a1055"]}
2024-01-31 16:04:53.757748   http://localhost:41224 <<< {"id":13,"jsonrpc":"2.0","result":{"blockHash":"0x3c6ee7b3019949e6fc255dd4ed53228e2707f1dd7517eaba0734858c3aebe65d","blockNumber":"0xfcbe","contractAddress":null,"cumulativeGasUsed":"0x67deaa","from":"0x2d93455b07bccf38e8d019f7f43a2c2d70b46b4e","gasUsed":"0x18162","logs":[{"address":"0xadf0cab6023ddf1814b3778c223fb0d2be25dc72","blockHash":"0x3c6ee7b3019949e6fc255dd4ed53228e2707f1dd7517eaba0734858c3aebe65d","blockNumber":"0xfcbe","data":"0x000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000000","logIndex":"0x0","polarity":false,"topics":["0xcd6e659e4c2e75c3bfe47fecaccf39aeb368116a0ee52afb532e07f6cba6c0d1","0x0000000000000000000000002d93455b07bccf38e8d019f7f43a2c2d70b46b4e","0x00000000000000000000000054e228d8fea148cfe2b109b3b152ff21321d09a2"],"transactionHash":"0x64dfadadd5b29b22c6e4b23225bfa4a4dd21aa18f3adb4eb61e2a0b6515a1055","transactionIndex":"0x44","type":"mined"}],"logsBloom":"0x00000000001000000000000000000000000000000000000000000000000000000000020002001000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000008000001000000200000000000000000000000000000000000000000000000000000000","status":"0x1","to":"0xadf0cab6023ddf1814b3778c223fb0d2be25dc72","transactionHash":"0x64dfadadd5b29b22c6e4b23225bfa4a4dd21aa18f3adb4eb61e2a0b6515a1055","transactionIndex":"0x44"}}

@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment