Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-388 Improve transaction method #544

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Conversation

badrogger
Copy link
Collaborator

Changes:

  • Added structures to simplify estimateGas calls parsing
  • Added TxRecordStatus to simplifiy parsing transaction records from TM

Testing:

  • No performance changes were made.
  • Modified existing tests covers code modifications.
  • Tested schain creation.

@badrogger badrogger changed the title IS-788 Improve transaction method IS-388 Improve transaction method Nov 10, 2023
@badrogger badrogger marked this pull request as ready for review November 10, 2023 17:49
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7fa8169) 90.75% compared to head (3727ce8) 90.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #544      +/-   ##
===========================================
+ Coverage    90.75%   90.86%   +0.11%     
===========================================
  Files           65       65              
  Lines         2466     2464       -2     
===========================================
+ Hits          2238     2239       +1     
+ Misses         228      225       -3     
Files Coverage Δ
skale/contracts/base_contract.py 92.98% <100.00%> (-0.57%) ⬇️
skale/transactions/result.py 89.65% <94.73%> (+8.57%) ⬆️
skale/wallets/redis_wallet.py 90.65% <95.23%> (-0.26%) ⬇️
skale/transactions/tools.py 92.63% <70.00%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger merged commit 7de8597 into develop Nov 13, 2023
8 checks passed
@badrogger badrogger deleted the improve-transaction-method branch November 13, 2023 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants