Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-388 Fix retry_tx decorator #543

Merged
merged 13 commits into from
Nov 10, 2023
Merged

IS-388 Fix retry_tx decorator #543

merged 13 commits into from
Nov 10, 2023

Conversation

badrogger
Copy link
Collaborator

Changes:

  1. Make retry_tx decorator reraise unhandled exceptions.
  2. Rework exception structure.

Testing:

  1. No performace changes were made.
  2. Tested schain creation on the local network.
  3. Modified exiting tests, added new tests to increase coverage

@badrogger badrogger marked this pull request as ready for review November 8, 2023 18:30
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (7c03914) 91.15% compared to head (b0d4f9b) 90.75%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #543      +/-   ##
===========================================
- Coverage    91.15%   90.75%   -0.40%     
===========================================
  Files           66       65       -1     
  Lines         2464     2466       +2     
===========================================
- Hits          2246     2238       -8     
- Misses         218      228      +10     
Files Coverage Δ
skale/transactions/exceptions.py 100.00% <100.00%> (ø)
skale/utils/exceptions.py 83.33% <ø> (-1.29%) ⬇️
skale/utils/web3_utils.py 86.13% <100.00%> (+0.20%) ⬆️
skale/wallets/__init__.py 100.00% <ø> (ø)
skale/wallets/common.py 80.64% <100.00%> (+1.33%) ⬆️
skale/wallets/sgx_wallet.py 98.36% <100.00%> (+0.36%) ⬆️
skale/contracts/base_contract.py 93.54% <92.30%> (+0.32%) ⬆️
skale/wallets/redis_wallet.py 90.90% <90.90%> (+0.09%) ⬆️
skale/transactions/tools.py 92.39% <87.50%> (-4.17%) ⬇️
skale/wallets/ledger_wallet.py 84.55% <83.33%> (+1.48%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badrogger badrogger merged commit 7fa8169 into develop Nov 10, 2023
7 of 10 checks passed
@badrogger badrogger deleted the fix-retry-tx branch November 10, 2023 12:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants