Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer changes #4

Open
jaykobi opened this issue Feb 14, 2017 · 1 comment
Open

composer changes #4

jaykobi opened this issue Feb 14, 2017 · 1 comment

Comments

@jaykobi
Copy link

jaykobi commented Feb 14, 2017

Hi,

first of all a big thank you for uploading that module! I already use it and it does it's job well.

To make it installable with composer directly you should have composer.json in the root directory. In fact, I think best practice is to put alle the code you now have under Sivajik34/CustomFee in the root directory directly. Composer will take take of creating those directories during installation.

Also the dependency for magento framework is out of date ("magento/framework": "~100.0.4"). I just installed with magento 2.1.3 and it worked so you should consider updating this, or composer will not let anybody install it.

Thanks for the great work.

@sivajik34
Copy link
Owner

Thank you for your feedback,i don't have enough time to work on this.you can contribute by forking the repo,make pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants