Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background thumbnail making up #53

Closed
RicardCots opened this issue Sep 17, 2024 · 6 comments
Closed

Background thumbnail making up #53

RicardCots opened this issue Sep 17, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@RicardCots
Copy link

Is your feature request related to a problem? Please describe.
Every background map should display a different thumbnail in SITMUN viewer acording to what is defined in the SITMUN administrator.

Describe the solution you'd like
The thumnail associated to each background map in the viewer should correspond to the image defined in the manager in the respective field (see attached image).

image

Therefore the sitmun API should attach the corresponding parameter to each background map.

image

@fjlopez
Copy link
Contributor

fjlopez commented Sep 17, 2024

@silmeUsil0001 , Is this feasible with the API SITNA? Could you provide a link to the docs?

@fjlopez fjlopez added the question Further information is requested label Sep 17, 2024
@RicardCots
Copy link
Author

I think so, in fact i guess API SITNA is expecting a thumbnail. @mvinent will provide the details.

IDENA example:
image

IDE menorca example:

image

@fjlopez
Copy link
Contributor

fjlopez commented Sep 20, 2024

I’ve just pushed changes to sitmun-backend-core that address the issue on the server-side. A thumbnail property has been added to the background description provided by the API.

@RicardCots I believe updating the viewer to support this new feature should be straightforward.

@fjlopez fjlopez added enhancement New feature or request and removed question Further information is requested labels Sep 20, 2024
@mvinent
Copy link
Contributor

mvinent commented Oct 25, 2024

Solved on this commit.

@mvinent mvinent closed this as completed Oct 25, 2024
@fjlopez
Copy link
Contributor

fjlopez commented Oct 28, 2024

@mvinent Could you add at least an screenshot of the viewer for each issue (#53, #59, #61, #63 and #64) showing how the commit has solved the issue? I need it to validate/reproduce locally your configuration for testing/understanding the solution.

@fjlopez fjlopez reopened this Oct 28, 2024
@mvinent
Copy link
Contributor

mvinent commented Nov 8, 2024

Fixed, admin takes the value, API response sends the value and viewer applies it.

Admin:
image

API Response:
image

Viewer:
image

@mvinent mvinent closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants