Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements for Robustness #3

Open
fjlopez opened this issue Jun 18, 2024 · 4 comments
Open

Enhancements for Robustness #3

fjlopez opened this issue Jun 18, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@fjlopez
Copy link
Contributor

fjlopez commented Jun 18, 2024

Describe the bug
Several areas need improvement:

  • The docker-compose.yml file does not use proper users and passwords, the PostgreSQL image is set to latest, and the volume for data is not defined.
  • The Docker files do not use slim or Alpine versions.
  • Not all the task data is loaded.
  • The default user for the Administration application is not admin:admin.
  • The README.md file does not contain an uninstall section.

To Reproduce

  • Clone the repository and navigate to the project directory.
  • Open the docker-compose.yml file and observe the lack of proper users and passwords, the implicit use of the latest PostgreSQL image, and the absence of a defined volume for data.
  • Open the Docker files and observe the absence of slim or Alpine versions.
  • Run the application and observe that not all task data is loaded and the default user for the Administration application is not admin:admin.
  • Open the README.md file and observe the absence of an uninstall section.

Expected behavior

  • Better naming in docker-compose.yml.
  • Volume persistence.
  • Fixed versions in images.
  • Updated data.
  • An uninstall section in the README.md file.
@fjlopez fjlopez added the enhancement New feature or request label Jun 18, 2024
@fjlopez fjlopez self-assigned this Jun 18, 2024
fjlopez added a commit that referenced this issue Jun 18, 2024
@fjlopez fjlopez closed this as completed Jun 26, 2024
@fjlopez fjlopez reopened this Jun 27, 2024
@fjlopez
Copy link
Contributor Author

fjlopez commented Jun 27, 2024

The loadData statements in the changelog must use lowercase file paths. This is particularly important because while Windows and macOS filesystems are often case-insensitive, Linux filesystems are case-sensitive. Using inconsistent case can lead to failures when the code is deployed in a Linux environment.

fjlopez added a commit that referenced this issue Jul 1, 2024
fjlopez added a commit that referenced this issue Jul 3, 2024
- Remove overwritten defaults of application-dev.yml
- Use upper case environment properties in docker-compose.yml; update README.md where required
- Add restart always in docker-compose.yml
- Make explicit secret in backend and proxy are the same
@fjlopez
Copy link
Contributor Author

fjlopez commented Jul 6, 2024

The reverse proxy configuration for the backend was incomplete. Headers required:

  • X-Forwarded-Proto
  • X-Forwarded-Host
  • X-Forwarded-Port
  • X-Forwarded-Prefix

@fjlopez
Copy link
Contributor Author

fjlopez commented Jul 15, 2024

Based on the dotGIS review, the following changes have been applied:

  • Environment Variable Management: Created a default .env file documenting each relevant property used in the Docker Compose file.
  • Docker Optimization: Implemented health checks in Dockerfiles and the Docker Compose file, and utilized string interpolation within the Docker Compose file.
  • Documentation: Simplified the structure of README.md, added links to services, and documented environment variables.

fjlopez added a commit that referenced this issue Jul 15, 2024
- Better environment variable management
- Healthchecks in docker
- Better documentation
@fjlopez
Copy link
Contributor Author

fjlopez commented Aug 12, 2024

Improvements for deployment with a reverse proxy

  • Environment Variable Management: Modified for setting up the Base URL based on the reverse proxy configuration
  • Docker Build: Base URL components injected in the build process.

fjlopez added a commit that referenced this issue Aug 12, 2024
fjlopez added a commit that referenced this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant