Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set down to 780 if not given #19

Open
ibc opened this issue Apr 22, 2019 · 4 comments
Open

Don't set down to 780 if not given #19

ibc opened this issue Apr 22, 2019 · 4 comments
Labels

Comments

@ibc
Copy link
Contributor

ibc commented Apr 22, 2019

Currently the command line and API is "all or nothing", meaning that if a parameter is not give (e.g. down) then a default value for it is chosen (in this case const defaultDown = 780).

Is there any reason to not force all values to be given and let some of them just unset (without a max value)?

@soulgalore
Copy link
Member

Hi @ibc no I don't think there's a reason, it just happened :) I agree it could be forced.

Best
Peter

@ibc
Copy link
Contributor Author

ibc commented Apr 23, 2019

Thanks. The thing is that, at least in my use-case, I want to limit uplink or bandwidth, and usually not both. And when I want to limit uplink I do not want to also limit downlink to some default value.

And chance to implement this behavior? :)

@ibc
Copy link
Contributor Author

ibc commented Apr 23, 2019

It also seems that rtt could be splitted into downDelay and upDelay (instead of assuming that the given rtt must be divided by 2 and applied to both down and up.

ibc added a commit to ibc/throttle that referenced this issue Apr 23, 2019
@soulgalore
Copy link
Member

I've fixed so you can set just one parameter (but you need to set at least one). For changing RTT, yeah maybe if we can make it backward compatible. I can test a PR for it if someone has the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants