-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set down
to 780 if not given
#19
Comments
Hi @ibc no I don't think there's a reason, it just happened :) I agree it could be forced. Best |
Thanks. The thing is that, at least in my use-case, I want to limit uplink or bandwidth, and usually not both. And when I want to limit uplink I do not want to also limit downlink to some default value. And chance to implement this behavior? :) |
It also seems that |
I've fixed so you can set just one parameter (but you need to set at least one). For changing RTT, yeah maybe if we can make it backward compatible. I can test a PR for it if someone has the time. |
Currently the command line and API is "all or nothing", meaning that if a parameter is not give (e.g.
down
) then a default value for it is chosen (in this caseconst defaultDown = 780
).Is there any reason to not force all values to be given and let some of them just unset (without a max value)?
The text was updated successfully, but these errors were encountered: