Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Download video of median run from WPT as part of the sitespeed report #1

Open
UltraNemesis opened this issue Sep 7, 2017 · 9 comments

Comments

@UltraNemesis
Copy link

Would it be possible to collect the video generated by WPT for the median run and put it along with the html report. We get video with browsertime in the result, but not for WPT.

@soulgalore
Copy link
Member

Yep I agree, we should add it. I tried it a year ago or so but then the HTML for the video that you got from the API had some privacy issues (I think you also got a js that made a call to New Relic if I remember correctly) but it could be that it only happens using the public version and not a private instance, I don't think I tested that. Let me try again.

@soulgalore
Copy link
Member

This means that I need some time to test, I can test this in a week or so.

@soulgalore
Copy link
Member

Ok here is what it would look like using iframe https://www.webpagetest.org//video//view.php?embed=1&id=170909_49ee1530fe4303cd88e5acad4d3159865907f06d so that will not work for privacy issues. But we could download the mp4. We need to make it configurable though.

@soulgalore
Copy link
Member

soulgalore commented Sep 10, 2017

Yep I think we should download each mp4 per run, then we have the same functionality as Browsertime. We need to call createVideo to create the video, and from the response we can take the video id: response.data.videoId and then finally download the video from https://WEBPAGETEST_HOST/video/download.php?id=VIDEO_ID

@UltraNemesis
Copy link
Author

I think video is automatically created with the default settings passed to WPT by sitespeed.io. Video is necessary for the speed index calculation. So, its only a matter of downloading the files.

{
  pollResults: 10,
  timeout: 600,
  includeRepeatView: false,
  private: true,
  aftRenderingTime: true,
  location: 'Dulles:Chrome',
  connectivity: 'Cable',
  video: true
}

@soulgalore
Copy link
Member

Hi @UltraNemesis it works like this: WPT records a video with FFMPEG, but only screenshots with changes are kept, and when you "create" the video those screenshots are put together to the video, that we can use.

@soulgalore
Copy link
Member

I'll take this up this week when WebPageTest is working, it will be really nice to have.

soulgalore referenced this issue in sitespeedio/sitespeed.io Sep 27, 2017
@soulgalore
Copy link
Member

Pushed a branch https://github.com/sitespeedio/sitespeed.io/tree/download-wpt-video where the video is downloading. One bug right now is that it downloads the same video independent of runs (how do the API work?) and we should have a way of turning it on/off. And when it turned on add it to the HTML result page.

@soulgalore
Copy link
Member

I think this is perfect for a WebPageTest user to take on.

@soulgalore soulgalore changed the title Collecting video of median run from WPT as part of the sitespeed report Downloadnvideo of median run from WPT as part of the sitespeed report Jan 26, 2019
@soulgalore soulgalore changed the title Downloadnvideo of median run from WPT as part of the sitespeed report Download video of median run from WPT as part of the sitespeed report Jan 26, 2019
@soulgalore soulgalore transferred this issue from sitespeedio/sitespeed.io Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants