fix: run webpagereplay using the GUI adding --webpagereplay (#65)

* fix: run webpagereplay using the GUI adding --webpagereplay
sitespeedio · Jul 30, 2024 · e63152b · e63152b
1 parent 11eed39
commit e63152b
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/testrunner/src/testrunners/docker-testrunner.js b/testrunner/src/testrunners/docker-testrunner.js
@@ -52,12 +52,13 @@ export default async function runJob(job) {
     );
 
     const parameters = setupDockerParameters(
-      job,
       dockerContainer,
       dockerExtraParameters,
       workingDirectory,
       configFileName,
-      resultFileName
+      resultFileName,
+      (job.data.extras && job.data.extras.includes('--webpagereplay')) ||
+        job.data.config.webpagereplay
     );
 
     if (job.data.scripting) {
@@ -150,12 +151,12 @@ async function handleScriptingFile(job, workingDirectory) {
 }
 
 function setupDockerParameters(
-  job,
   dockerContainer,
   dockerExtraParameters,
   workingDirectory,
   configFileName,
-  resultFileName
+  resultFileName,
+  usingWebPageReplay
 ) {
   const baseParameters = [
     'run',
@@ -172,9 +173,9 @@ function setupDockerParameters(
     true
   ];
 
-  if (job.data.config.webpagereplay) {
-    baseParameters.splice(1, 0, '--cap-add=NET_ADMIN');
-    baseParameters.splice(2, 0, '-e', 'REPLAY=true', '-e', 'LATENCY=100');
+  //
+  if (usingWebPageReplay) {
+    baseParameters.splice(1, 0, '-e', 'REPLAY=true', '-e', 'LATENCY=100');
   }
   return baseParameters;
 }