Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding single prototypes does not work reliably #99

Open
nezaniel opened this issue Mar 8, 2019 · 2 comments
Open

Hiding single prototypes does not work reliably #99

nezaniel opened this issue Mar 8, 2019 · 2 comments

Comments

@nezaniel
Copy link
Member

nezaniel commented Mar 8, 2019

Given the following configuration (and LazyBones installed)
Sitegeist: Monocle: hiddenPrototypeNamePatterns: - 'Sitegeist.Lazybones:Image' - 'Sitegeist.Lazybones:Picture' - 'My.Package:Component.*'
The following takes effect:

  • Sitegeist.Lazybones:Picture is hidden (as expected)
  • Sitegeist.Lazybones:Image is visible (unexpected)
  • My.Package:Component.* is hidden (as expected)
@kdambekalns
Copy link
Contributor

I'd suggest to move this to a comment on #89 and close this issue as duplicate.

@bwaidelich
Copy link
Contributor

The configuration from above (with fixed indention):

Sitegeist:
  Monocle:
    hiddenPrototypeNamePatterns:
      - 'Sitegeist.Lazybones:Image'
      - 'Sitegeist.Lazybones:Picture'
      - 'My.Package:Component.*'

It's unexpected that this won't work for Sitegeist.Lazybones:Image and #89 won't solve that (mostly for b/c reasons). But with #89 you could do:

Sitegeist:
  Monocle:
    hiddenPrototypeNamePatterns:
      - 'Sitegeist.Lazybones:*'
      - 'My.Package:Component.*'
    alwaysShowPrototypes:
      - 'Sitegeist.Lazybones:Some.Component.To.Be.Included'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants