Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode of LinearDiscretizer on an array using SampleBinCenter appears to still use SampleUniform #37

Closed
dylan-asmar opened this issue Nov 27, 2024 · 1 comment
Assignees

Comments

@dylan-asmar
Copy link

using Discretizers
binedges = [0, 0.5, 1]
lineardisc = LinearDiscretizer(binedges)

decode_1 = decode(lineardisc, 1, SampleBinCenter()) # 0.25
decode_2 = decode(lineardisc, 2, SampleBinCenter()) # 0.75
decode_12 = decode(lineardisc, [1, 2], SampleBinCenter()) # Random sampling from bins

@info decode_1 == decode_12[1]
@info decode_2 == decode_12[2]

Running this code currently outputs false for both.

@tawheeler tawheeler self-assigned this Nov 28, 2024
@tawheeler
Copy link
Contributor

Thank you!
Fixed in f33800c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants