Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should rand, count, etc. use DataFrames directly? #70

Open
mykelk opened this issue Aug 19, 2017 · 0 comments
Open

Should rand, count, etc. use DataFrames directly? #70

mykelk opened this issue Aug 19, 2017 · 0 comments

Comments

@mykelk
Copy link
Member

mykelk commented Aug 19, 2017

We have changed some of the code to use Table, which wraps DataFrame. It has the field potential. Should tables be interpreted solely as representations of potentials (in this case probability distributions)? Or should we have one Table type that holds all kinds of tables, e.g., samples, counts, weighted samples, conditional probability tables, etc.? And, if so, should we rename potential to something else (perhaps, df)?

I'd especially like to know what @tawheeler and @hamzaelsaawy think. Let me know and I'll implement it over the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant