-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loopy Belief inference is only implemented for a single node. #48
Comments
@hamzaelsaawy - if you could address this that'd be excellent. |
With regards to this and #49, I have a new Factor type, and an inference type. I've been struggling with this; I don't think LBP supports multiple queries, since it just returns the marginal of any one node (given the evidence) by message passing, not the joint of multiple nodes. I think ... |
If you have multiple query variables, you can turn them into a vector variable, and then proceed with the LBP algorithm. |
agreed that LBP won't return the joint but I think that one would expect a LBP call with multiple query nodes to return the marginals for each node, which you already have after the LBP loop terminates? |
We could just take the factor product over all resulting marginal factors that correspond to query variables. |
I introduced a new inference API:
Likelihood and exact inference work perfectly under this.
Loopy belief, however, only takes a
query::NodeName
, when aVector{NodeName}
would be ideal.The text was updated successfully, but these errors were encountered: