Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New default method detected as METHOD_NEW_DEFAULT when BinaryIncompatible disabled and SourceIncompatible enabled #361

Closed
WencongLiu opened this issue Aug 31, 2023 · 1 comment

Comments

@WencongLiu
Copy link

WencongLiu commented Aug 31, 2023

Hello community,

I added a new default method to a class and only set SourceIncompatible to true. The BinaryIncompatible is set to false. The configuration is below:
<breakBuildOnBinaryIncompatibleModifications>false</breakBuildOnBinaryIncompatibleModifications> <breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>

But japicmp plugin detects that there is METHOD_NEW_DEFAULT. The version of japicmp is 0.17.1.1_m325.

Should adding default method to an interface be detected as METHOD_NEW_DEFAULT when only SourceIncompatible is set to true ?

@siom79
Copy link
Owner

siom79 commented Sep 2, 2023

Duplicate of #289

@siom79 siom79 marked this as a duplicate of #289 Sep 2, 2023
@siom79 siom79 closed this as completed Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants