Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming AWS ACL Changes #145

Open
zleight1 opened this issue Dec 14, 2022 · 0 comments
Open

Upcoming AWS ACL Changes #145

zleight1 opened this issue Dec 14, 2022 · 0 comments

Comments

@zleight1
Copy link
Contributor

zleight1 commented Dec 14, 2022

Back in 2020 I had done some work here to add ACL configs for AWS - see PR, it's been a few years but I think originally the issue was the deployer assumed the bucket access was public-read only so we needed to add more ACL options - see issue.

Anyways, it seems like AWS is changing the default way bucket access/ACLs work come April 2023 and if I understand correctly any new buckets created will have issues using the import-map-deployer as-is unless they specifically set the ACL to the previous behavior, which many people would miss. It seems that existing buckets should be OK, but my guess is that these will eventually need to be migrated.

Any new buckets that need to use import-map-deployer could have issues either with the API calls (since we'd still be sending ACLs) and config or with the ownership changes (might need specific user rights and would be good to document).

The blog post can be found here

This isn't necessarily an issue but more of a discussion (but it will be an issue/PR eventually is my guess), so my first question is:

  • Should we make changes to the way the ACL config works in the deployer?
    Note also there could be a situation of mixed old/new bucket types so we might need a fallback or additional type of flag, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant