Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md with virtualenv information #16

Open
dmosorast opened this issue Oct 29, 2018 · 1 comment
Open

Update README.md with virtualenv information #16

dmosorast opened this issue Oct 29, 2018 · 1 comment
Labels
enhancement good first issue This is something that should be fairly easy to contribute even if you're unfamiliar with singer.

Comments

@dmosorast
Copy link
Contributor

dmosorast commented Oct 29, 2018 •
edited
Loading

According to the Singer Getting Started guide, taps and targets should be run in separate virtual environments.

In an effort to improve documentation, this should be reflected in the READMEs of the canonical "starter" taps/targets, this repo being one of them.

Requested Change
Adapt the command from the getting started guide to be the first step of this repo's README in a way that works in conjunction with tap-exchangeratesapi (replace tap-fixerio with this one, as it's the current no-configuration tap since Fixer changed their API).
@dmosorast dmosorast added enhancement good first issue This is something that should be fairly easy to contribute even if you're unfamiliar with singer. labels Oct 29, 2018
@rseabrook rseabrook mentioned this issue Jan 11, 2019
Merged
@cgardens
Copy link

cgardens commented Oct 2, 2020

Should we close this ticket? Seems like the fix was successfully merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue This is something that should be fairly easy to contribute even if you're unfamiliar with singer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgardens @dmosorast