Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YUI compressor #3

Open
elado opened this issue Jun 2, 2010 · 3 comments
Open

YUI compressor #3

elado opened this issue Jun 2, 2010 · 3 comments

Comments

@elado
Copy link

elado commented Jun 2, 2010

YUI compressor is much better than jsmin.

I'm not that familiar with github, otherwise I would have forked it, but here's a fix:

http://gist.github.com/422436

(changed only minify_js method)

And of course, put yuicompressor-2.4.2.jar in minify directory, downloadable at:
http://yuilibrary.com/downloads/#yuicompressor

(I should really know how to use github :) )

Thanks.

@sinefunc
Copy link
Owner

sinefunc commented Jun 4, 2010

Yeah problem with using YUI is that we have to make sure every deployment also has java, which is a major assumption.

With Jsmin, it's just plain ruby.

I'm going to compare the compression ratios of both and see if it warrants itself enough to require java to do JS compression.

@elado
Copy link
Author

elado commented Jun 4, 2010

It can always be inside begin/rescue with a warning if one doesn't have java.
YUI compressed my file 20% more because it also obfuscates code (which is important for code protection).

@sinefunc
Copy link
Owner

sinefunc commented Jun 7, 2010

Ok we'll see what we can do with this. We're leaning towards environment vars though, something like

COMPRESSOR=/path/to/yui.jar rake minify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants