-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally preserve current stack #98
Comments
I'm ok with adding this, but I think the option is ambiguous. I'm asking myself, which stack is it preserving. |
I think it's going to be hard to encapsulate the entire behavior and raison d'être in a property name, especially since the main verb here is "deserialize error" rather than "create error" Names:
I think |
I assumed you would just want the |
Correct, check my |
An issue I found when throwing deserialized errors is that the thrown error has no reference to this
throw
point.I think the "correct" way to throw serialized errors would be something like:
Two drawbacks:
new Error
doesn't benefit from Preserve error constructor #70So how about:
The text was updated successfully, but these errors were encountered: