Enumerable properties are made non-enumerable

[MikeJerred]

Enumerable properties are made non-enumerable after deserialization.

import { deserializeError, serializeError } from 'serialize-error';

class MyError extends Error {
  constructor(public params: any) {
    super('test');
  }
}

const error = new MyError({ name: 'foo' });
const serialized = serializeError(error);
const deserialized = deserializeError(serialized) as MyError;

// properties of deserialized.params are non-enumerable

Minimal reproduction: https://stackblitz.com/edit/typescript-dkbp39?file=index.ts

[twschiller]

➕ We came across this also with a nested property named message. Perhaps related to names that are Error instance properties?

Update: it looks like it's the list here: https://github.com/sindresorhus/serialize-error/blob/main/index.js#L19

[fregante]

When serializing, this metadata is lost, so the module just renders those known properties non-enumerable as defined in that list. I'm not sure why that happens for params though, it might be the default.

Additionally in @twschiller's case, the object is being deserialized as an error when it isn't, because of this loose check:

serialize-error/index.js

Line 194 in a2df3ae

export function isErrorLike(value) {

In this specific case the fix would be to specific type obj.message === 'string'. I will send a PR today.