Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private repo with SSL certificate and key #35

Open
alexan opened this issue Jul 12, 2017 · 5 comments
Open

Private repo with SSL certificate and key #35

alexan opened this issue Jul 12, 2017 · 5 comments

Comments

@alexan
Copy link

alexan commented Jul 12, 2017

While debugging sindresorhus/update-notifier#100 I noticed this module does not use npm-config ssl properties:

I want to create a PR for this issue how would you proceed?

  • is there a module like registry-url or registry-auth-token which returns this information
    • should I create such a module?
  • should registry-auth-token return this information?
  • I also found no solution adding ssl infos to got. Is it possible to switch the request lib?
@wejendorp
Copy link

You said it all. I'd also like this to work with these certificate options.

@sindresorhus sindresorhus changed the title private repo with ssl cert and key Private repo with SSL certificate and key May 17, 2018
@m11m
Copy link

m11m commented Jul 2, 2018

As a temporary fix, we could pass the rejectUnauthorized through?

https://nodejs.org/api/tls.html#tls_new_tls_tlssocket_socket_options

@m11m
Copy link

m11m commented Jul 2, 2018

#44

@sindresorhus
Copy link
Owner

is there a module like registry-url or registry-auth-token which returns this information
should I create such a module?

Create a new module or add the logic to this module. Up to you.

should registry-auth-token return this information?

I don't think it would fit into the goal of that module.

I also found no solution adding ssl infos to got

Got passes all option down to https://nodejs.org/api/https.html#https_https_request_options_callback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants