Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency broken under Node 12 #48

Closed
thirstyfish opened this issue May 24, 2019 · 6 comments
Closed

Dependency broken under Node 12 #48

thirstyfish opened this issue May 24, 2019 · 6 comments

Comments

@thirstyfish
Copy link

The ref package is currently broken on Node 12:
TooTallNate/ref#107

I'm guessing this means it won't compile on the new Electron 5 on windows and this issue is related:
#41
@VigneshVaidyanathan
Copy link

Any update or workaround for this?

@Janealter
Copy link
Contributor

This dependency can be replaced by ref-napi in the main package and in ref-wchar, in ref-struct. In this case, active-win will work on Node 12. I checked this.

@Janealter
Copy link
Contributor

Janealter commented Sep 26, 2019 •
edited
Loading

I created fork with Node 12 support https://github.com/Janealter/active-win-12
I can make PR in this repository, if @sindresorhus needs it.

@sindresorhus
Copy link
Owner

A PR would be great.

@Janealter
Copy link
Contributor

Check #58

@sindresorhus
Copy link
Owner

Fixed by #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sindresorhus @thirstyfish @VigneshVaidyanathan @Janealter