Incorrect error reporting from prefer-global-this rule

[charles4221]

I just upgraded my version of the plugin to 56.0.0 and started getting lint errors for the prefer-global-this rule on code like this:

export function detectPrefersDarkMode() {
  return (
    typeof window !== 'undefined' &&
    window.matchMedia('(prefers-color-scheme: dark)').matches
  );
}

Shouldn't this type of usage be excluded from this rule since globalThis.matchMedia will crash with a TypeError: globalThis.matchMedia is not a function?

The above example is also a common use case in apps that run on both server and client, to check that the browser environment exists before running browser-specific code. globalThis isn't going to work for those use cases.

[sindresorhus]

This is a faulty check. You can no longer make this assumption, regardless of this rule. The correct way is to test the individual functions. I think this rule is doing you a favor by leading you to a better pattern.

export function detectPrefersDarkMode() {
  return globalThis.matchMedia?.('(prefers-color-scheme: dark)').matches ?? false
}

[fregante]

Duplicate of #2468