All locales and plugins are bundled in consuming apps

[bartocc]

Starting with 0.11.0 (the embroider v2 version of this addon), all dayjs locales and plugins end up in the final bundle

See my comments here: e4f8ca4#r117661519

[sinankeskin]

v0.12.1 has been released. Should be ok now. Could you please check?

[bartocc]

unfortunately, 0.12.1 does not solve the issue. I really believe the template string dayjs/locale/${locale}.js is the culprit here

[sinankeskin]

Yeap I see all locales still bundling. I'll investigate but as far as I know there is no sync way to import yet.

If you have any solution feel free to create a PR.

Thanks for the report.

[bartocc]

Maybe a solution would be to have this addon only provide helpers.
The dayjs lib, locales and plugins inclusions would be the responsibility of the consuming apps.

If I remember correctly, ember-moment did the same when they realized that the moment library was bundled twice

[sinankeskin]

Maybe a solution would be to have this addon only provide helpers. The dayjs lib, locales and plugins inclusions would be the responsibility of the consuming apps.

If I remember correctly, ember-moment did the same when they realized that the moment library was bundled twice

@bartocc I think that's the only way to fix this properly. I'll try to create a new major version exactly like that when I get some free time. Thanks for the suggestion.