Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Dshot & Bi-directional Dshot support #431

Open
lida2003 opened this issue Sep 9, 2024 · 4 comments
Open

[FEATURE]Dshot & Bi-directional Dshot support #431

lida2003 opened this issue Sep 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@lida2003
Copy link

lida2003 commented Sep 9, 2024

Describe the solution you'd like
Support Dshot & Bi-directional Dshot like AM32, https://github.com/am32-firmware/AM32/blob/main/Src/dshot.c

@lida2003 lida2003 added the enhancement New feature or request label Sep 9, 2024
@Candas1
Copy link
Collaborator

Candas1 commented Sep 9, 2024

Hi,

This is a motor control library, I am not sure a communication protocol belongs here.
Ideally someone would create a library for dshot, have you checked if there is one already?
There are libraries for other protocols.

@runger1101001
Copy link
Member

I'm with Candas on this - it's unlikely we would add Dshot support to the core library.

But we would be happy to add it in our drivers library if the implementation can be made in a fairly simple way without external library dependencies.

Otherwise, I think a seperate project would be best, which we would be happy to host/fork in the simplefoc organisation.

Note: I think it would be an interesting addition for sure, I have been looking at this and ExpressLRS and it would be cool to have a simple to configure setup for people to use in combination with controlling SimpleFOC.

@Candas1
Copy link
Collaborator

Candas1 commented Sep 9, 2024

Looks like it requires timers + DMA.
An example here : https://github.com/mokhwasomssi/stm32_hal_dshot
So this would required separate implementation for arduino,stm,esp, ....

@lida2003
Copy link
Author

lida2003 commented Sep 9, 2024

it's unlikely we would add Dshot support to the core library.

This is a motor control library, I am not sure a communication protocol belongs here.

The repo was added a long time ago. When I posted this issue, I hadn't realized that this is a FOC (Field-Oriented Control) library.

Otherwise, I think a seperate project would be best, which we would be happy to host/fork in the simplefoc organisation.

Currently, AM32 uses sinusoidal control. And I think it would be better to use FOC control. Is there any project(firmware) for Arduino-FOC library used for FPV ESC?

Looks like it requires timers + DMA.

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants