Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging param validation checks on startup #264

Open
jlashner opened this issue Apr 28, 2022 · 0 comments
Open

Logging param validation checks on startup #264

jlashner opened this issue Apr 28, 2022 · 0 comments

Comments

@jlashner
Copy link
Collaborator

jlashner commented Apr 28, 2022

Currently it seems like if ocs_agent.param validation checks fail on startup, it's impossible to tell from the logs.

For example, the ocs-magpie agent there is a task set_monitored_channels which will fail the validation if chan_info contains more than 6 channels. When running this on startup with more than 6 channels, the task won't actually run, but the agent won't crash and there is nothing in the logs that makes it clear that the param validation failed. The logs in this case look like this:

2022-04-26T17:36:30-0400 startup-op: launching set_monitored_channels
2022-04-26T17:36:30-0400 start called for set_monitored_channels
2022-04-26T17:36:30-0400 send:1 Status is now "running".
2022-04-26T17:36:30-0400 read:0 Status is now "running".
2022-04-26T17:36:30-0400 send:1 Status is now "running".
2022-04-26T17:36:30-0400 set_monitored_channels:2 Set monitored channels
2022-04-26T17:36:30-0400 set_monitored_channels:2 Status is now "done".

Failing param-checks on startup should probably crash the agent or at least log that the task failed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant