You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently it seems like if ocs_agent.param validation checks fail on startup, it's impossible to tell from the logs.
For example, the ocs-magpie agent there is a task set_monitored_channels which will fail the validation if chan_info contains more than 6 channels. When running this on startup with more than 6 channels, the task won't actually run, but the agent won't crash and there is nothing in the logs that makes it clear that the param validation failed. The logs in this case look like this:
2022-04-26T17:36:30-0400 startup-op: launching set_monitored_channels
2022-04-26T17:36:30-0400 start called for set_monitored_channels
2022-04-26T17:36:30-0400 send:1 Status is now "running".
2022-04-26T17:36:30-0400 read:0 Status is now "running".
2022-04-26T17:36:30-0400 send:1 Status is now "running".
2022-04-26T17:36:30-0400 set_monitored_channels:2 Set monitored channels
2022-04-26T17:36:30-0400 set_monitored_channels:2 Status is now "done".
Failing param-checks on startup should probably crash the agent or at least log that the task failed out.
The text was updated successfully, but these errors were encountered:
Currently it seems like if ocs_agent.param validation checks fail on startup, it's impossible to tell from the logs.
For example, the ocs-magpie agent there is a task
set_monitored_channels
which will fail the validation ifchan_info
contains more than 6 channels. When running this on startup with more than 6 channels, the task won't actually run, but the agent won't crash and there is nothing in the logs that makes it clear that the param validation failed. The logs in this case look like this:Failing param-checks on startup should probably crash the agent or at least log that the task failed out.
The text was updated successfully, but these errors were encountered: