Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site_config to use wildcard string for generic matching, rather than localhost #263

Open
BrianJKoopman opened this issue Apr 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@BrianJKoopman
Copy link
Member

When identifying the host and updating site.hub, site_config.get_config checks for the given site_host, the hostname of the computer, or 'localhost' in the site config file. Use of 'localhost' in the SCF should be discouraged.

This is done here:

host_attempts = [socket.gethostname(), 'localhost']

'localhost' should be replace with some unique wildcard string, i.e. '*default*', and a warning should be issued when it's used. The idea being that if you know the hostname, that should be configured in the SCF. Else, you're probably using this wildcard for some local testing on a single node.

@BrianJKoopman BrianJKoopman added the enhancement New feature or request label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant