-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing LS372 ops #35
Comments
others to add: I don't feel very strongly about |
A recent request from site - enable entering parameters for custom_pid in order to servo the focal plane from ocs-web. |
For custom_pid, docstring says:
However, it will actually accept float for I'll get the panel ready but consider whether you want to adjust how args are handled. |
Great point. This updates to allow floats everywhere: simonsobs/socs#548 |
How should custom_pid be situated with respect to the other operations on the panel? After "set_pid"? |
Hmm, good question. I don't really have a strong opinion on where. Those PID commands are two different PIDs though, so I'm not sure if users will find that confusing (or perhaps already do...) |
I believe all the requested ops are now implemented. |
Definitely engage_channel, maybe others.
The text was updated successfully, but these errors were encountered: