Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing LS372 ops #35

Closed
mhasself opened this issue Jun 24, 2023 · 7 comments
Closed

Missing LS372 ops #35

mhasself opened this issue Jun 24, 2023 · 7 comments

Comments

@mhasself
Copy link
Member

Definitely engage_channel, maybe others.

@sanahabhimani
Copy link

sanahabhimani commented Aug 24, 2023

input_configfile would be super helpful, is that feasible?

others to add: engage_autorange, get_input_setup

I don't feel very strongly about set_calibration_curve because that's a likely one-off event that happens in the beginning (and input_configfile addresses calibration curve setup) but telescope folks may disagree

@BrianJKoopman
Copy link
Member

A recent request from site - enable entering parameters for custom_pid in order to servo the focal plane from ocs-web.

@mhasself
Copy link
Member Author

For custom_pid, docstring says:

P (int) – Proportional value in Watts/Kelvin
I (int) – Integral Value in Hz
update_time (int) – Time between PID updates in seconds

However, it will actually accept float for I. But I think all three of these could / should be floats, in the agent.

I'll get the panel ready but consider whether you want to adjust how args are handled.

@BrianJKoopman
Copy link
Member

Great point. This updates to allow floats everywhere: simonsobs/socs#548

@mhasself
Copy link
Member Author

How should custom_pid be situated with respect to the other operations on the panel? After "set_pid"?

@BrianJKoopman
Copy link
Member

Hmm, good question. I don't really have a strong opinion on where. Those PID commands are two different PIDs though, so I'm not sure if users will find that confusing (or perhaps already do...)

@mhasself
Copy link
Member Author

I believe all the requested ops are now implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants