Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify adequate stability of likelihood values #113

Open
itrharrison opened this issue Mar 1, 2023 · 1 comment
Open

Identify adequate stability of likelihood values #113

itrharrison opened this issue Mar 1, 2023 · 1 comment
Assignees
Labels
help wanted Extra attention is needed question Further information is requested tests Improvements to tests

Comments

@itrharrison
Copy link
Collaborator

In e.g. #112 and #97 we have seen precomputed likelihood values change on O(0.01%) depending on the CAMB version. At the moment likelihood value stability is checked using np.isclose which has default settings on accuracy of rtol=1.e05, atol=1.e-8.

We should identify what rtol and atol values are actually appropriate for the SO likelihood codes.

@itrharrison itrharrison added help wanted Extra attention is needed question Further information is requested tests Improvements to tests labels Mar 1, 2023
@itrharrison
Copy link
Collaborator Author

TAC advice is that third decimal place accuracy should be adequate. I would propose that tests using allclose should have tolerances updated to reflect this, with the values being some package-wide parameter which can be changed if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested tests Improvements to tests
Projects
None yet
Development

No branches or pull requests

2 participants