Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipDestructiveCodeActions is deprecated in favor of mode #127

Open
simonhaenisch opened this issue May 31, 2024 · 0 comments
Open

skipDestructiveCodeActions is deprecated in favor of mode #127

simonhaenisch opened this issue May 31, 2024 · 0 comments

Comments

@simonhaenisch
Copy link
Owner

export interface OrganizeImportsArgs extends CombinedCodeFixScope {
    /** @deprecated Use `mode` instead */
    skipDestructiveCodeActions?: boolean;
    mode?: OrganizeImportsMode;
}

export const enum OrganizeImportsMode {
    All = "All",
    SortAndCombine = "SortAndCombine",
    RemoveUnused = "RemoveUnused",
}

https://github.com/microsoft/TypeScript/blob/fa58c615a43d0c2c9ed60ef4ff4783da91c0ce32/src/services/types.ts#L728-L732

Should follow this and

  1. expose the mode option
  2. mark skipDestructiveCodeActions as deprecated as well (for removal in next major version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant