Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration screen: invalid code message isn't highlighted as invalid #33

Open
robbieaverill opened this issue Aug 2, 2019 · 5 comments

Comments

@robbieaverill
Copy link
Contributor

4.0 with SS 4.3.x

image

Should be red to follow Bootstrap conventions

@robbieaverill
Copy link
Contributor Author

robbieaverill commented Aug 23, 2019

Still an issue. Related: silverstripe/silverstripe-security-extensions#15.

@brynwhyman
Copy link

Adding the release milestone.

@emteknetnz emteknetnz self-assigned this Jul 20, 2020
@emteknetnz
Copy link
Member

emteknetnz commented Jul 20, 2020

The words "Provided code was not valid" uses the css variable
--color-message-error

This is defined in the mfa module

mfa-variables.scss

$color-message-error: rgba(169, 30, 46, 1); // #a91e2e
...
:root
  ...
  --color-message-error: #{$color-message-error};

However it's currently rendering as #71141f (different from screenshot in OP) which is coming from login-forms darkmode.css

Theres some wider stuff going on here, I think this needs further investigation before attempting a solution on the totp module

@emteknetnz emteknetnz removed their assignment Jul 20, 2020
@emteknetnz
Copy link
Member

Also need to confirm if the input border is supposed to have a red border on error like the sudo mode does
silverstripe/silverstripe-security-extensions#34

Currently the red border does not show on the totp module

@emteknetnz
Copy link
Member

Possibly related silverstripe/silverstripe-mfa#383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants