FIX Don't swallow relevant BadMethodCallExceptions from ViewLayerData #11482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fairly sure the Update: All CI failures match what's on the |
GuySartorelli
force-pushed
the
pulls/6/badmethodcall
branch
from
ea1ab5b to
678f26d
Compare
GuySartorelli
commented
Nov 28, 2024
Comment on lines
-27
to
+30
| return call_user_func_array([$this->customised, $method], $arguments ?? []); | ||
| return $this->customised->$method(...$arguments); | ||
| } | ||
|
|
||
| return call_user_func_array([$this->original, $method], $arguments ?? []); | ||
| return $this->original->$method(...$arguments); |
There was a problem hiding this comment.
Needed because call_user_func_array shows up in the stack trace and would result in throwing the exception instead of ignoring it. See https://github.com/silverstripe/silverstripe-framework/actions/runs/12062241360/job/33635620688?pr=11482
emteknetnz
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, scenarios "exception thrown outside __call()" and "exception thrown in __call() in a different class hierarchy" would fail.
Issue
BadMethodCallExceptiongets swallowed up byViewLayerData#11481