Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should ditch this #22

Open
GuySartorelli opened this issue Sep 20, 2022 · 3 comments
Open

We should ditch this #22

GuySartorelli opened this issue Sep 20, 2022 · 3 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Sep 20, 2022

This is barely used - the only place it's used by us directly is in graphql, and even there it's only to provide hooks that aren't likely widely used.
We should abandon this module and replace the graphql hooks with https://symfony.com/doc/current/components/event_dispatcher.html or plain Silverstripe-style extensions

@passchn
Copy link

passchn commented Jun 22, 2023

What is the state of this package? It seems like you have to install an unstable version of this if you want to use silverstripe-cms ^5. See also: brandcom/silverstripe-vite#3

Will there be a stable version?

@GuySartorelli
Copy link
Member Author

@passchn Sorry about that, I've tagged a stable release now. Thank you for bringing this to our attention.

@passchn
Copy link

passchn commented Jun 26, 2023

Ok, didn't test it, but that should have solved the issue :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants